building out two new rounding methods as is discussed in #227 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woo! Issues being patched! I don't know what a negative precision means, so its probably a mistake. I'd say make it an exception. Also before this can be accepted it needs documentation. It should go along with the other |
|
Ya I knew these were not merge ready yet more the request for feedback first thing. But with that out of the way... you has new changes to review. |
|
Ping? |
files and leave everything else to be explicit. Also add io->url() for opening URLs.
|
appears to be fixed on my box but seeing as it looks like I borked the rebase to catch up others should really review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done as two methods as I suggested. Currently round_to_precision modifies users input with out notification. Is this an issue that should be addressed (ie warn) or is there ever a case where one would expect 1.2345->round_to_precision(-0.234) to actually do something useful?